Skip to content

Fix typo in PR template#144

Merged
bretbrownjr merged 1 commit intobemanproject:mainfrom
wusatosi:pr-typo
Mar 14, 2025
Merged

Fix typo in PR template#144
bretbrownjr merged 1 commit intobemanproject:mainfrom
wusatosi:pr-typo

Conversation

@wusatosi
Copy link
Copy Markdown
Member

@wusatosi wusatosi commented Mar 14, 2025 •
edited
Loading

Description

This PR fixes a typo in the current PR template, which is breaking current CI check on main.

Motivation and Context

Current lint check on main is breaking due to this typo.

Testing

I have manually ran:

⋊> ~/b/exemplar on pr-typo ◦ pre-commit run --color=always --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
clang-format.............................................................Passed
CMake linting............................................................Passed
markdownlint.............................................................Passed
codespell................................................................Passed

Meta

  • If all approvals are obtained and the PR is green, any Beman member can merge the PR.

@wusatosi wusatosi requested a review from a team March 14, 2025 23:45
bretbrownjr
bretbrownjr approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bretbrownjr bretbrownjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@bretbrownjr bretbrownjr merged commit bdad9ee into bemanproject:main Mar 14, 2025
@wusatosi
Copy link
Copy Markdown
Member Author

wusatosi commented Mar 14, 2025

Nice catch!

I might should have caught this when I merged the original PR 👉👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bretbrownjr bretbrownjr bretbrownjr approved these changes

@neatudarius neatudarius neatudarius approved these changes

@camio camio Awaiting requested review from camio camio is a code owner

@dietmarkuehl dietmarkuehl Awaiting requested review from dietmarkuehl dietmarkuehl is a code owner

@steve-downey steve-downey Awaiting requested review from steve-downey steve-downey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wusatosi @bretbrownjr @neatudarius