Update CODEOWNERS: append core-reviewers to CODEOWNERS#130
Conversation
|
@bemanproject/beman-codeowners test tag |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
neatudarius
requested review from
bretbrownjr,
camio,
dietmarkuehl,
steve-downey and
wusatosi
as code owners
There was a problem hiding this comment.
I object to this change.
Every PR opened will notify folks in this file according to current policy.
There is already complaints from folks about receiving too much automated emails from GitHub about beman.
And currently @bemanproject/beman-codeowners has a greater scope than current code owner.
What is the motivation of this change?
Please check latest sync meeting notes - we lack of codeowners in same repos and we deciced to take an action item to enforce more reviewers. So that was already decided. If you are not happy with notifications, I can pull you out from the Team and just keep @wusatosi where is it today. Do you prefer to put the group on last position in the list? |
Okay I see what you're referring to now. I was a bit confused on this. Let's move the conversation to bemanproject/beman#99 |
wusatosi
left a comment
wusatosi
left a comment
There was a problem hiding this comment.
Update:
Context for this PR: This is to expand the group of reviewers to reduce the queue for review.
Blocking merge as I think this team name is non-descriptive, that conversation redirect to underlying standard change: #130 .
I will approve once that is resolved.
wusatosi
left a comment
wusatosi
left a comment
There was a problem hiding this comment.
Delegate decision on concern to @bemanproject/leads .
|
I've made a suggestion on #bemanproject/beman/pull/99 that can hopefully move things forward. |
|
@neatudarius Looks like the codespell linter is complaining about a typo: |
That's on main and it's solved by @wusatosi in #131 (comment) |
neatudarius
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
6 participants
Issue: bemanproject/beman#101
Apply REPOSITORY.CODEOWNERS - bemanproject/beman#99