Support BUILD_SHARED_LIBS#104
Merged
bretbrownjr merged 2 commits intomainfrom Jan 27, 2025
Merged
Conversation
## Problem Hardcoding STATIC is unneeded and breaks support for the standard CMake feature `BUILD_SHARED_LIBS`. ## Solution Remove `STATIC` from the `add_library(exemplar)` statement and allow CMake defaults to provide a default static library build. ## Reference For `add_library` supporting `BUILD_SHARED_LIBS`: https://cmake.org/cmake/help/latest/command/add_library.html Docs for `BUILD_SHARED_LIBS`, including that `STATIC` is the default for CMake built libraries. https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS
bretbrownjr
requested review from
camio,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
Member
Author
|
Hardcoding |
wusatosi
approved these changes
Jan 26, 2025
Member
wusatosi
left a comment
wusatosi
left a comment
There was a problem hiding this comment.
Seems like a very reasonable update for me.
neatudarius
approved these changes
Jan 27, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
LGTM 👍
Please open an issue here https://github.com/bemanproject/beman/issues. We need to update the Beman Standard and all repos.
This was referenced Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hardcoding STATIC is unneeded and breaks support for the standard CMake feature
BUILD_SHARED_LIBS.Solution
Remove
STATICfrom theadd_library(exemplar)statement and allow CMake defaults to provide a default static library build.Reference
For
add_librarysupportingBUILD_SHARED_LIBS:https://cmake.org/cmake/help/latest/command/add_library.html
Docs for
BUILD_SHARED_LIBS, including thatSTATICis the default for CMake built libraries.https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS