Skip to content

Some proposed clarifications #289

Open

Description

@matty0ung
  • vessel_pressure is ambiguous. It doesn’t say whether it’s gauge or absolute, or whether it’s a target or a measured value. dotBeer chose gauge, which is what brewers quote.
  • calories_per_pint doesn’t say which pint. The 3.0 changelog names this ambiguity, but there’s no issue for it. One option is an energy quantity with a unit, as dotBeer’s energy_content does.
  • UnitUnitType has five values with unstated differences. These are 1, unit, each, dimensionless and pkg. Either define how they differ, or pick one canonical value and deprecate the rest. dotBeer uses count.
  • PercentType has no bounds. Alpha acid of 150% validates. A bounded 0–100 variant, like dotBeer’s PercentageSimple vs PercentageNoMax, would catch real errors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions