Skip to content

Inconsistent unit types #218

New issue
New issue
Open
Open
Inconsistent unit types#218

Description

@pasztordaniel
pasztordaniel
opened on Feb 27, 2025

I have found some inconsistent units:

  • in water.json, the WaterType's ph property is simple number not acidity_unit_type
  • in recipe.json, the RecipeType's carbonation property is simple number not carbonation_unit_type
  • in fermentable.json, the FermentableType's alpha_amylase is a simple number. Is this property percentage or mass?
  • in packaging_vessel.json, the PackagingVesselType's carbonation property is simple number not carbonation_unit_type

Activity

  1. matty0ung commented on Mar 25, 2026

    @matty0ung
    matty0ung
    on Mar 25, 2026
    Contributor

    AIUI alpha_amylase is measured in "dextrinizing units". (One α-amylase dextrinizing unit is defined as the quantity of α-amylase that will dextrinize soluble starch in the presence of an excess of β-amylase at the rate of 1 g/h at 30°C. Or, at least, that's what it says at https://www.deerland.com/wp-content/uploads/2015/04/EnzymeAssayUnits_Deerland.pdf.)

    I agree with you about the other points. See also #207.

  2. ndreno
    added a commit that references this issue on Aug 27, 2026

    Fix the doc/type generator, migrate to JSON Schema 2020-12, and add c…

    d1ca159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions