Repository navigation
Inconsistent capitalisation of pH #208
Description
In the names of AcidityType fields, the schema, in some places, uses pH, eg:
TimingType.pH
WaterType.pH
RecipeType.beer_pH
but in other places it uses ph, eg:
FermentableType.di_ph
FermentationStepType.start_ph
FermentationStepType.end_ph
It's not a huge deal, but it would be nice to be more consistent.
Reacted by Ellis
Activity
krutilin commentedon Apr 17, 2024
Which one to choose? pH or ph?
matty0ung commentedon May 23, 2026
In Brewtarget, we use "pH", as it's more readable, even though it's "against" our other capitalisation rules. So I would vote for that. 😸
Fix the doc/type generator, migrate to JSON Schema 2020-12, and add c…
Fix fluoride, add the wheat culture type, clarify timing.time
Fix fluoride, add the wheat culture type, clarify timing.time
Fix fluoride, add the wheat culture type, clarify timing.time
Fix fluoride, add the wheat culture type, clarify timing.time (#250)