public_ configuration refactoring #2133
Conversation
wheatley
changed the title
…logic from public_port
OTR-ActiveRecord update: added to manually call the database connection
| # | ||
| # context name for the beef_url_str method when using this | ||
| # to say that this is the hook url | ||
| def hook_url | ||
| beef_url_str | ||
| end |
There was a problem hiding this comment.
This is a bit of a strange API choice as hook_url doesn't include the hook file path portion of the URL.
There was a problem hiding this comment.
happy to change that to append the file path.
There was a problem hiding this comment.
A helper for the proto://host:port base URL is useful, as evidenced by the many instances where this helper is used without appending the hook path. My concern is that the API is confusing. hook_url is not the hook URL.
There was a problem hiding this comment.
updated and appended the hook_file property
| beef_port = @configuration.get("beef.http.public_port") || @configuration.get("beef.http.port") | ||
| beef_hook = @configuration.get("beef.http.hook_file") | ||
| hook_url = "#{beef_proto}://#{beef_host}:#{beef_port}/#{beef_hook}" | ||
| hook_url = BeEF::Core::Configuration.instance.hook_url |
There was a problem hiding this comment.
This isn't a one-for-one replacement as hook_url doesn't include the hook path portion of the URL. I'm not sure if that matters.
There was a problem hiding this comment.
ill check that out, and get back to you, I think it joins the hook file later, but I may be wrong
There was a problem hiding this comment.
updated and appended the hook_file property
|
are we keen for a public section under http? public |
wheatley
changed the base branch from
master
to
feature/1785_public_host_port
3 participants
work in process for the configuration changes relating to public configuration variables