renamed the WebCloner model class to align with ActiveRecord syntax #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed WebCloner name changes in web_cloner.rb created two tests to support changeswq
Contributor
Author
|
This pull request address the defects listed in issue #2010 |
Contributor
Author
|
hey @bcoles is it possible to have a quick review of this pull request |
Collaborator
|
Confirmed this resolved the issue. I will presume that the spec test works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed WebCloner name changes in web_cloner.rb
created two tests to support changeswq
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Extension Defect
Feature/Issue Description
Issue with persistence of a cloned web site.
Model was not named inline with ActiveRecord syntax and therefore the table could not be found.
Test Cases
Create a basic model create test, improvement required would be to add a checking expect
Created a test of the entire web cloning functionality, there is an improvement of using the beef auth page instead off google.com