Skip to content

ARE New Zombie Execution Error #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcrew99 merged 2 commits into from
Jul 9, 2020
Merged

ARE New Zombie Execution Error #1957

jcrew99 merged 2 commits into from
Jul 9, 2020

Conversation

@jackdwalker
Copy link
Contributor

@jackdwalker jackdwalker commented Jul 6, 2020 •
edited
Loading

Thanks for submitting a PR! Please fill in this template where appropriate:

Category

Bug

Feature/Issue Description

This fix solves the error described in issue 1932.

Describe What Changes

As per my description in the issue:

During the Autorun execution process there was an issue with the BeEF::Core::Models::Execution object that was created. The function creating it was creating it with a :rule_id key (see lines 88 → 96 in core/main/autorun_engine/engine.rb). According to the executions object in the Database Schema page in the Wiki, this key should simply be called :id. This small change seemed to fix the problem!

Test Cases

N/A

Relevant Wiki Page

AutoRunEngine
Database Schema - Execution Model

@jackdwalker jackdwalker changed the title Are new execution error ARE New Zombie Execution Error Jul 6, 2020
@jackdwalker jackdwalker mentioned this pull request Jul 6, 2020
Closed
@jackdwalker jackdwalker linked an issue Jul 6, 2020 that may be closed by this pull request
Autorun rules not working #1932
Closed
@jcrew99
Copy link
Contributor

jcrew99 commented Jul 7, 2020

Right, this seems to work locally but i haven't been able to receive the same error when running the auto run rules either. Has pinkbat1's issue been resolved by the change or have you been able to fix the error fully with the change? ( i saw you said you got it locally)

@jackdwalker
Copy link
Contributor Author

jackdwalker commented Jul 8, 2020

@jcrew99 - I was able to reproduce his error by following the steps he outlined in the issue template. This patch fixed the error he was receiving :)

@jcrew99
Copy link
Contributor

jcrew99 commented Jul 9, 2020

Cool, great work on it!

@jcrew99 jcrew99 merged commit 7fa269f into master Jul 9, 2020
@wheatley wheatley mentioned this pull request Aug 12, 2021
Closed
@wheatley wheatley deleted the are_new_execution_error branch September 4, 2021 05:24
@bcoles
Copy link
Collaborator

bcoles commented Apr 1, 2023

The issue was that the schema was missing the :rule_id attribute and the Autorun Engine attempting to store executions using the session attribute instead of session_id. This was later patched in d417645.

The patch in this PR was later reverted in #2782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autorun rules not working

4 participants

@jackdwalker @jcrew99 @bcoles