Skip to content

Pretty Theft Missing Credentials JS Error #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcrew99 merged 2 commits into from
Jul 9, 2020
Merged

Pretty Theft Missing Credentials JS Error #1956

jcrew99 merged 2 commits into from
Jul 9, 2020

Conversation

@jackdwalker
Copy link
Contributor

@jackdwalker jackdwalker commented Jul 6, 2020

Thanks for submitting a PR! Please fill in this template where appropriate:

Category

Bug

Feature/Issue Description

This feature solves the issues described in issue 1950.

Describe what changes

As per my description of the issue in the issue itself:

The checker function was trying to access the DOM element with ID 'buttonpress'. It was trying to access it from the document.body.lastChild object instead of directly from document. document.body.lastChild does not have the .getElementById method, which was causing the error. It works for me locally now.

Test cases

N/A

Relevant wiki page

N/A

@jackdwalker jackdwalker linked an issue Jul 6, 2020 that may be closed by this pull request
Hello, beef and facebook #1950
Closed
@jackdwalker jackdwalker mentioned this pull request Jul 6, 2020
Closed
@jackdwalker jackdwalker changed the title Pretty theft empty credentials error Pretty Theft Missing Credentials JS Error Jul 6, 2020
@jcrew99
Copy link
Contributor

jcrew99 commented Jul 7, 2020

Works for me locally, seems good to merge, would like someone to look over as well if possible

@jcrew99 jcrew99 requested review from bcoles and jcrew99 July 7, 2020 12:29
@jackdwalker
Copy link
Contributor Author

jackdwalker commented Jul 8, 2020 •
edited
Loading

@jcrew99 - pretty comfortable merging this one. The user who created the #1950 has closed it as resolved after implementing the code in this PR. Small change to specifically the module - so there is little to no risk of impact elsewhere.

No need for bcoles to review, I've explained my patch in the issue thread and he's acknowledged that the fix makes sense.

@jackdwalker jackdwalker removed the request for review from bcoles July 9, 2020 00:17
@jcrew99
Copy link
Contributor

jcrew99 commented Jul 9, 2020

Good point, sounds good

@jcrew99 jcrew99 merged commit b0c0e6e into master Jul 9, 2020
@wheatley wheatley mentioned this pull request Aug 12, 2021
Closed
@wheatley wheatley deleted the pretty_theft_empty_credentials_error branch September 4, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcrew99 jcrew99 jcrew99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hello, beef and facebook

3 participants

@jackdwalker @jcrew99