Added excluded_hooking_subnet config option #1879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@icamys That looks interesting, are you able to a rspec test for this before we can merge it? |
Author
|
@jcrew99 Actually, I've created the pull request with zero-knowledge of ruby, so, unfortunately, I'm not familiar with rspec or any other ruby-related tools. |
bcoles
reviewed
May 14, 2020
Comment on lines
+48
to
+59
| excluded_hooking_subnet = config.get('beef.restrictions.excluded_hooking_subnet') | ||
| unless excluded_hooking_subnet.nil? || excluded_hooking_subnet.empty? | ||
| found = true | ||
| excluded_hooking_subnet.each do |subnet| | ||
| found = false if IPAddr.new(subnet).include?(request.ip) | ||
| end | ||
|
|
||
| unless found | ||
| BeEF::Core::Logger.instance.register('Target Range', "Attempted hook from excluded hooking subnet (#{request.ip}) rejected.") | ||
| error 404 | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
The logic for found is inverted, which is especially confusing to read with the final unless conditional.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1878.