Replace autocomplete_theft with get_autocomplete_creds #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have run this on firefox and chrome latest and they both work. Had some initial trouble test case wise so i hopped onto a few different sites i use to test the functionality. It will have me sending some emails later about setting proper csp policy's on login forms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace autocomplete_theft module with get_autocomplete_creds.
The autocomplete_theft sucked. get_autocomplete_creds is more useful.
In retrospect, iterating over a bunch of potential inputs is probably entirely unnecessary.
This probably won't work on latest Chrome, and may not work on latest Firefox.