Implement local config #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mentioned in CHANGELOG, and in the current cfg file... but there's no actual code to look for it!
Mostly reorganization to bring all examples of a type of config directive near the docs for it. But also adding on to those docs a bit. The actual default working configuration is at the end of the file.
|
merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config file and the Changelog both talk about a local configuration file. People keep trying to use it, see for example #3 .
But the joke's on us... the code doesn't actually even try to load any file by that name. (Even accounting for the
mcpe-vizvsbedrock-vizrenaming.)So I added logic to look for both the base config
bedrock-viz.cfgand a local additionsbedrock-viz.local.cfgin the search path it was already using. Also refactored the code to be a little less bizarre. Also documented it for users.