Fix GitHub-flavored markdown task list checkboxes being detected as links (#121)

Copilot · web-flow · commit a598a5570ff4 · 2025-12-13T14:30:46.000+01:00
diff --git a/src/link_extractors/markdown_link_extractor.rs b/src/link_extractors/markdown_link_extractor.rs
@@ -39,7 +39,8 @@ impl LinkExtractor for MarkdownLinkExtractor {
             None
         };
 
-        let parser = Parser::new_with_broken_link_callback(text, Options::empty(), Some(callback));
+        let parser =
+            Parser::new_with_broken_link_callback(text, Options::ENABLE_TASKLISTS, Some(callback));
 
         for (evt, range) in parser.into_offset_iter() {
             match evt {
@@ -493,4 +494,27 @@ mod tests {
         assert_eq!(result[0].as_ref().unwrap().target, "http://a.com/");
         assert_eq!(result[1].as_ref().unwrap().target, "http://c.com/");
     }
+
+    #[test]
+    fn gfm_checkbox_not_link() {
+        let le = MarkdownLinkExtractor();
+        let input = "- [x] checked task\n- [ ] unchecked task";
+        let result = le.find_links(input);
+        // GitHub-flavored markdown task list checkboxes should NOT be treated as links
+        assert!(
+            result.is_empty(),
+            "Task list checkboxes should not be detected as links: {:?}",
+            result
+        );
+    }
+
+    #[test]
+    fn gfm_checkbox_with_link() {
+        let le = MarkdownLinkExtractor();
+        let input = "- [x] [actual link](http://example.com/)\n- [ ] unchecked task";
+        let result = le.find_links(input);
+        // Only the actual link should be detected, not the checkboxes
+        assert_eq!(1, result.len());
+        assert_eq!(result[0].as_ref().unwrap().target, "http://example.com/");
+    }
 }
