progression items should come out of the major_items pool, not the mi…#12
Merged
beauxq merged 3 commits intobeauxq:ff6wcfrom May 30, 2025
bigmalletman:patch-1
Merged
progression items should come out of the major_items pool, not the mi…#12beauxq merged 3 commits intobeauxq:ff6wcfrom bigmalletman:patch-1
beauxq merged 3 commits intobeauxq:ff6wcfrom
bigmalletman:patch-1
Conversation
…nor_items pool, when treasuresanity is on Thanks to Gemini for helping me find this bug. This resulted in more good items (like Illuminas and Ragnarok Swords) than there should have been.
beauxq
reviewed
May 29, 2025
change self.multiworld.random to self.random
logic simplification for filler item generation as suggested by @beauxq
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progression items should come out of the major_items pool, not the minor_items pool, when treasuresanity is on
Thanks to Gemini for helping me find this bug.
This resulted in more good items (like Illuminas and Ragnarok Swords) than there should have been.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
When Treasuresanity is ON, progression items from deduct from major_items, not minor_items.
What is this fixing or adding?
Too many good items in the item pool when Treasuresanity is on.
How was this tested?
I generated a few times and checked my item pools in the spoiler log.
If this makes graphical changes, please attach screenshots.