Ensure valid_hash? returns a Boolean#227
Merged
tenderlove merged 1 commit intobcrypt-ruby:masterfrom Jul 21, 2020
Merged
Conversation
nathanKramer
force-pushed
the
fix/valid-hash-return-type
branch
from
d1ec908 to
212799f
Compare
I noticed that valid_hash? returns either nil or 0, in the usual cases. Since the docs list valid_hash? as returning a Boolean, I thought this might be a bug. at the very least I suspect think this would be less confusing.
nathanKramer
force-pushed
the
fix/valid-hash-return-type
branch
from
212799f to
eb567cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
valid_hash?returns eithernilor0.Since the docs list valid_hash? as returning a Boolean, I thought this might be a bug.