Skip to content

Commit b0de385

Browse files
authored
fix(web): support Shift+Insert terminal paste (pingdotgg#5982)
1 parent c7b14a8 commit b0de385

2 files changed

Lines changed: 21 additions & 1 deletion

File tree

‎apps/web/src/terminal/ghostty/surface.test.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,22 @@ describe("isTerminalPasteShortcut", () => {
253253
true,
254254
);
255255
});
256+
257+
it("supports the conventional Shift+Insert paste shortcut", () => {
258+
expect(isTerminalPasteShortcut(event({ key: "Insert", shiftKey: true }), "Linux x86_64")).toBe(
259+
true,
260+
);
261+
expect(isTerminalPasteShortcut(event({ key: "Insert" }), "Linux x86_64")).toBe(false);
262+
expect(
263+
isTerminalPasteShortcut(
264+
event({ key: "Insert", ctrlKey: true, shiftKey: true }),
265+
"Linux x86_64",
266+
),
267+
).toBe(false);
268+
expect(isTerminalPasteShortcut(event({ key: "Insert", shiftKey: true }), "MacIntel")).toBe(
269+
false,
270+
);
271+
});
256272
});
257273

258274
describe("isTerminalCompositionCommitInput", () => {

‎apps/web/src/terminal/ghostty/surface.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,11 @@ export function isTerminalPasteShortcut(
340340
event: Pick<KeyboardEvent, "ctrlKey" | "key" | "metaKey" | "shiftKey">,
341341
platform = navigator.platform,
342342
) {
343-
if (event.key.toLowerCase() !== "v") return false;
343+
const key = event.key.toLowerCase();
344+
if (key === "insert" && !isMacPlatform(platform)) {
345+
return event.shiftKey && !event.ctrlKey && !event.metaKey;
346+
}
347+
if (key !== "v") return false;
344348
return isMacPlatform(platform) ? event.metaKey : event.ctrlKey && event.shiftKey;
345349
}
346350

0 commit comments

Comments
 (0)