Skip to content

Use neostandard + add more static code analysis #142

Merged
voxpelli merged 5 commits into
masterfrom
use-neostandard
Jul 2, 2024
Merged

Use neostandard + add more static code analysis #142
voxpelli merged 5 commits into
masterfrom
use-neostandard

Conversation

@voxpelli

@voxpelli voxpelli commented Jul 2, 2024

Copy link
Copy Markdown
Collaborator

This replaces standard with neostandard and:

Also:

  • adds rimraf, because there's a dependency on it that worked when standard made it be included
  • adds knip to help avoid the above
  • cleaned up stuff and refactored some stuff to help knip
  • added installed-check to ensure that the engine range is good

@voxpelli
voxpelli requested a review from bcomnes July 2, 2024 13:31
@voxpelli voxpelli self-assigned this Jul 2, 2024
@socket-security

socket-security Bot commented Jul 2, 2024

Copy link
Copy Markdown

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: eval, filesystem, unsafe +82 9.81 MB eslintbot
npm/[email protected] Transitive: environment, filesystem, shell +66 4.66 MB voxpelli
npm/[email protected] environment Transitive: filesystem, shell, unsafe +82 30.9 MB webpro
npm/[email protected] Transitive: environment, filesystem, unsafe +75 33.2 MB voxpelli
npm/[email protected] environment, filesystem Transitive: shell +23 3.2 MB isaacs

View full report↗︎

@voxpelli voxpelli changed the title Use neostandard Use neostandard + add more static code analysis Jul 2, 2024
@bcomnes

bcomnes commented Jul 2, 2024

Copy link
Copy Markdown
Owner

Thanks for doing all of that. No breaking changes right?

@voxpelli

voxpelli commented Jul 2, 2024

Copy link
Copy Markdown
Collaborator Author

Only such change would be the narrowing of the engine definition to match that of the dependencies, else nothing 😌

@voxpelli

voxpelli commented Jul 2, 2024

Copy link
Copy Markdown
Collaborator Author

@bcomnes You want me to merge or you will merge? :)

@bcomnes

bcomnes commented Jul 2, 2024

Copy link
Copy Markdown
Owner

I won't have time till later so feel free.

@voxpelli
voxpelli merged commit 25738ae into master Jul 2, 2024
@voxpelli
voxpelli deleted the use-neostandard branch July 2, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants