Scatter highlight tests#2
Merged
bclehmann merged 4 commits intobclehmann:scatter-highlightfrom May 23, 2020
Merged
Conversation
Author
|
There is one point to discuss, i write test for adding nonexisted index to highlight List. And expected function must trow exception. You have to make a decision that to do with incorrect indexes:
|
Owner
|
I think staying as it is is probably fine, you give the example of the plot being modified, and I think that's a fair reason to not be strict with the user. |
bclehmann
pushed a commit
that referenced
this pull request
Jun 30, 2023
RangePlot plottable and cookbook entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Add unit tests for ScatterHighlight math.
Addtionaly replace tabs with spaces back in
IHighlightable.csandPlottableScatter.cs. VS don't show the difference, but github grabs it as changes.I can't commit to you PR directly, but can make PR to you fork branch.
New functionality (code):
change
HighlightIndexessignature fromprivatetoprotected. This allow test its values in derived test class.New functionality (image):
Only math of public api
IHighligtablewas tested.