Skip to content

Translation scoping - if GetScopeFromComponent fails, use GetActiveSceneId instead of -1#619

Merged
ManlyMarco merged 1 commit intobbepis:masterfrom
Lmeks:patch-1
Nov 15, 2024
Merged

Translation scoping - if GetScopeFromComponent fails, use GetActiveSceneId instead of -1#619
ManlyMarco merged 1 commit intobbepis:masterfrom
Lmeks:patch-1

Conversation

@Lmeks
Copy link
Copy Markdown
Contributor

@Lmeks Lmeks commented Nov 14, 2024

@ManlyMarco
Copy link
Copy Markdown
Collaborator

ManlyMarco commented Nov 14, 2024

Did you test the build? I can build it for you for testing if needed.

@Lmeks
Copy link
Copy Markdown
Contributor Author

Lmeks commented Nov 15, 2024 •
edited
Loading

Do you mean the debug build?
Well, I checked that ignoring -1 return fixes #set level scoping in my case (BepInEx-IL2CPP 5.3.1, I couldnt change the font on 5.4), so yeah it works perfectly on my system.
Honestly I hadn't considered that it can break something or something. I haven't tried it in a case where half of the stuff is not broken.

@ManlyMarco ManlyMarco changed the title Fixed TranslationScopeHelper.GetScope logic Translation scoping - if GetScopeFromComponent fails, use GetActiveSceneId instead of -1 Nov 15, 2024
@ManlyMarco ManlyMarco merged commit 7b741c0 into bbepis:master Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManlyMarco ManlyMarco ManlyMarco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lmeks @ManlyMarco