Extend API for disposables collection #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new extension methods to DisposableListExtensions and introduces comprehensive test coverage for disposable list operations. The changes also reorganize test files into a dedicated Disposables folder structure.
- Added
Addmethod with params support and fluentThenAddmethods toDisposableListExtensions - Created comprehensive test suite
DisposableListExtensionsTestscovering all extension methods - Moved and updated
StateDisposablesTestsnamespace to align with folder structure
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Assets/UniState/Runtime/Core/Disposables/DisposableListExtensions.cs | Added new extension methods for adding multiple disposables and fluent API support |
| Assets/UniStateTests/EditMode/Disposables/DisposableListExtensionsTests.cs | New test file with comprehensive coverage of all extension methods |
| Assets/UniStateTests/EditMode/Disposables/StateDisposablesTests.cs | Updated namespace from Common to Disposables to match folder structure |
| Assets/UniStateTests/EditMode/Common/StepsLoggerTests.cs | Incorrectly changed namespace to Disposables |
| Assets/UniStateTests/EditMode/Disposables.meta | Unity meta file for new Disposables folder |
| Assets/UniStateTests/EditMode/Disposables/*.meta | Unity meta files for new test files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.