This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Merged
Conversation
keith
force-pushed
the
ks/update-rules_apple-to-0.31.3
branch
2 times, most recently
from
e327f8c to
b61ede3
Compare
keith
force-pushed
the
ks/update-rules_apple-to-0.31.3
branch
from
b61ede3 to
3283d5c
Compare
keith
commented
Aug 8, 2021
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")\ | ||
| \ | ||
| git_repository(\ | ||
| \ name = "bazel_skylib",\ |
Member
Author
There was a problem hiding this comment.
since tulsi doesn't actually reference skylib I think it's fair to not mess with this here, this caused issue because rules_apple patches this repo, we could apply the same patch here but that just feels leaky
keith
added a commit
to keith/continuous-integration
that referenced
this pull request
Aug 8, 2021
Fixed in bazelbuild/tulsi#268
This was referenced Aug 8, 2021
philwo
pushed a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Aug 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258