Skip to content

#185, add removeprefix/removesuffix to the spec#193

Merged
laurentlb merged 2 commits intobazelbuild:masterfrom
ndmitchell:remove_prefix_suffix
Feb 15, 2022
Merged

#185, add removeprefix/removesuffix to the spec#193
laurentlb merged 2 commits intobazelbuild:masterfrom
ndmitchell:remove_prefix_suffix

Conversation

@ndmitchell
Copy link
Copy Markdown
Contributor

No description provided.

@ndmitchell ndmitchell requested a review from laurentlb as a code owner May 28, 2021 10:10
@google-cla google-cla Bot added the cla: yes label May 28, 2021
@stepancheg
Copy link
Copy Markdown
Contributor

This method was added in Python 3.9, I cannot even play with it on my laptop

Perhaps clarify that prefix is removed no more than once. (e. g. "aaaaaax".removeprefix("a") removes only first "a").

PEP: https://www.python.org/dev/peps/pep-0616/

@ndmitchell
Copy link
Copy Markdown
Contributor Author

Clarified as per your suggestion

Copy link
Copy Markdown
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(and sorry for the delay)

@laurentlb laurentlb force-pushed the remove_prefix_suffix branch from 55caf1b to 7329175 Compare February 15, 2022 21:54
@laurentlb laurentlb merged commit d6a52c5 into bazelbuild:master Feb 15, 2022
@ndmitchell ndmitchell deleted the remove_prefix_suffix branch February 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants