Add FreeBSD toolchain.#85
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it. |
|
CLAs look good, thanks! |
|
Lgtm, but I'm not sure we want the default rules to include everything by default, though it probably costs nothing. @acmcarther any thoughts? |
|
Thanks for sending out this PR dforsyth@! I don't see any reason to be opposed to this, but I would like start generating these definitions in the near future if possible. The list of platforms is quite extensive: As it stands this toolchain won't be part of the test suite and I'm not sure if it makes sense to try to add it to the suite, so I'll submit now. If you have any thoughts on that @dforsyth + @mfarrugi I'd love to hear them. |
* Add support for depending on shared libraries on linux. * Use portable bash for TMPDIR check. * Move example 'matrix' to 'ffi/rust_calling_c'. * Use toolchain to get dylib/staticlib file extensions. * Skip dylib test targets on osx. * Simplify presubmit config. * Fix skipped labels. * Allow `rust_binary` to depend on `cc_library` (#83) The error message and the documentation both say this is possible. Light testing seems to show that this is the only change required. * Skip just rpath setup on non-linux. * Address review comments. * Attempt to clarify _setup_deps * Adjust provider test for field changes. * Actually provide correct patterns in test * Undo removing skipping of os check * Add FreeBSD toolchain. (#85) * Add os field to freebsd toolchain.
This is a pretty simple (mostly copy/paste) change to add support for FreeBSD.