Skip to content

Add FreeBSD toolchain.#85

Merged
acmcarther merged 1 commit intobazelbuild:masterfrom
dforsyth:enable_freebsd
May 23, 2018
Merged

Add FreeBSD toolchain.#85
acmcarther merged 1 commit intobazelbuild:masterfrom
dforsyth:enable_freebsd

Conversation

@dforsyth
Copy link
Copy Markdown
Contributor

This is a pretty simple (mostly copy/paste) change to add support for FreeBSD.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dforsyth
Copy link
Copy Markdown
Contributor Author

I signed it.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@mfarrugi
Copy link
Copy Markdown
Collaborator

Lgtm, but I'm not sure we want the default rules to include everything by default, though it probably costs nothing.

@acmcarther any thoughts?

@acmcarther
Copy link
Copy Markdown
Collaborator

Thanks for sending out this PR dforsyth@!


I don't see any reason to be opposed to this, but I would like start generating these definitions in the near future if possible. The list of platforms is quite extensive:
https://www.rust-lang.org/en-US/other-installers.html#standalone

As it stands this toolchain won't be part of the test suite and I'm not sure if it makes sense to try to add it to the suite, so I'll submit now. If you have any thoughts on that @dforsyth + @mfarrugi I'd love to hear them.

@acmcarther acmcarther merged commit 634a6f3 into bazelbuild:master May 23, 2018
acmcarther pushed a commit that referenced this pull request May 23, 2018
* Add support for depending on shared libraries on linux.

* Use portable bash for TMPDIR check.

* Move example 'matrix' to 'ffi/rust_calling_c'.

* Use toolchain to get dylib/staticlib file extensions.

* Skip dylib test targets on osx.

* Simplify presubmit config.

* Fix skipped labels.

* Allow `rust_binary` to depend on `cc_library` (#83)

The error message and the documentation both say this is possible. Light
testing seems to show that this is the only change required.

* Skip just rpath setup on non-linux.

* Address review comments.

* Attempt to clarify _setup_deps

* Adjust provider test for field changes.

* Actually provide correct patterns in test

* Undo removing skipping of os check

* Add FreeBSD toolchain. (#85)

* Add os field to freebsd toolchain.
@dforsyth dforsyth deleted the enable_freebsd branch May 28, 2018 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants