Avoid direct references to volatile files#3361
Merged
Merged
Conversation
UebelAndre
force-pushed
the
crate_universe
branch
from
March 18, 2025 14:50
f9cd632 to
de366ca
Compare
UebelAndre
marked this pull request as ready for review
March 18, 2025 14:50
This was referenced Mar 18, 2025
Merged
Contributor
|
Hi @UebelAndre, I tried this PR out in our repo via single_version_override on rules_rust 0.59.1. It successfully removed cargo and rustc from appearing in the lockfile and our linux CI and darwin developer machines now generate the same lockfiles. Thanks! |
illicitonion
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3297