Skip to content

Use repo-mapping-aware runfiles API in rust-analyzer#2666

Merged
illicitonion merged 1 commit intobazelbuild:mainfrom
hermeticbuild:zbarsky/runfiles
May 31, 2024
Merged

Use repo-mapping-aware runfiles API in rust-analyzer#2666
illicitonion merged 1 commit intobazelbuild:mainfrom
hermeticbuild:zbarsky/runfiles

Conversation

@dzbarsky
Copy link
Copy Markdown
Contributor

@dzbarsky dzbarsky commented May 25, 2024

Fixes #2615 and #2438

@dzbarsky
Copy link
Copy Markdown
Contributor Author

@fmeum @matts1 want to take a look?

@dzbarsky dzbarsky changed the title Use repo-mapping aware runfiles API in rust-analyzer Use repo-mapping-aware runfiles API in rust-analyzer May 25, 2024
@dzbarsky dzbarsky force-pushed the zbarsky/runfiles branch from cc71edd to b8c2ffd Compare May 25, 2024 03:30
@dzbarsky dzbarsky force-pushed the zbarsky/runfiles branch from b8c2ffd to d515f6a Compare May 25, 2024 03:33
illicitonion
illicitonion previously approved these changes May 31, 2024
Copy link
Copy Markdown
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion added this pull request to the merge queue May 31, 2024
@illicitonion illicitonion removed this pull request from the merge queue due to a manual request May 31, 2024
Comment thread tools/rust_analyzer/lib.rs
@illicitonion illicitonion self-requested a review May 31, 2024 00:09
@illicitonion illicitonion dismissed their stale review May 31, 2024 00:09

Realised I had a question

@illicitonion illicitonion added this pull request to the merge queue May 31, 2024
Merged via the queue into bazelbuild:main with commit dc08bde May 31, 2024
rrbutani referenced this pull request in bazel-contrib/toolchains_llvm Jun 10, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_rust | bazel_dep | minor | `0.45.1` -> `0.46.0` |
| [rules_rust](https://togithub.com/bazelbuild/rules_rust) |
http_archive | minor | `0.45.1` -> `0.46.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_rust (rules_rust)</summary>

###
[`v0.46.0`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.46.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_rust/compare/0.45.1...0.46.0)

##### 0.46.0

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-F8U7+AC5MvMtPKGdLLnorVM84cDXKfDRgwd7/dq3rUY=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.46.0/rules_rust-v0.46.0.tar.gz"],
)
```

Additional documentation can be found at:
https://bazelbuild.github.io/rules_rust/#setup

##### What's Changed

- fix: default rustfmt version to supplied rust version by
[@&#8203;mattem](https://togithub.com/mattem) in
[https://github.com/bazelbuild/rules_rust/pull/2660](https://togithub.com/bazelbuild/rules_rust/pull/2660)
- Use repo-mapping-aware runfiles API in rust-analyzer by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/rules_rust/pull/2666](https://togithub.com/bazelbuild/rules_rust/pull/2666)
- Fix protobuf generated srcs to include all sources by
[@&#8203;matts1](https://togithub.com/matts1) in
[https://github.com/bazelbuild/rules_rust/pull/2676](https://togithub.com/bazelbuild/rules_rust/pull/2676)
- Fix cargo_build_script executables. by
[@&#8203;matts1](https://togithub.com/matts1) in
[https://github.com/bazelbuild/rules_rust/pull/2675](https://togithub.com/bazelbuild/rules_rust/pull/2675)
- crate_universe: Don't include crate name in build script path. by
[@&#8203;criemen](https://togithub.com/criemen) in
[https://github.com/bazelbuild/rules_rust/pull/2663](https://togithub.com/bazelbuild/rules_rust/pull/2663)
- Ensure dynamic library dependencies end up in the runfiles directory
by [@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[https://github.com/bazelbuild/rules_rust/pull/2671](https://togithub.com/bazelbuild/rules_rust/pull/2671)
- use bazel_ci_rules bazel_dep instead of http_archive by
[@&#8203;mmorel-35](https://togithub.com/mmorel-35) in
[https://github.com/bazelbuild/rules_rust/pull/2678](https://togithub.com/bazelbuild/rules_rust/pull/2678)
- Ensure that running `bazel build` on a cargo_build_script target
actually runs the build script by
[@&#8203;matts1](https://togithub.com/matts1) in
[https://github.com/bazelbuild/rules_rust/pull/2680](https://togithub.com/bazelbuild/rules_rust/pull/2680)
- Allow overriding crate universe packages to local packages by
[@&#8203;ograff](https://togithub.com/ograff) in
[https://github.com/bazelbuild/rules_rust/pull/2674](https://togithub.com/bazelbuild/rules_rust/pull/2674)
- Depend on a copy of rustfmt for the target by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[https://github.com/bazelbuild/rules_rust/pull/2685](https://togithub.com/bazelbuild/rules_rust/pull/2685)
- \[Bugfix] Convert metadata keys to screaming snake case instead of
screaming kebab case in `cargo_build_script_runner` by
[@&#8203;Pagten](https://togithub.com/Pagten) in
[https://github.com/bazelbuild/rules_rust/pull/2682](https://togithub.com/bazelbuild/rules_rust/pull/2682)
- Add support for override_target when using bzlmod by
[@&#8203;AmeliasCode](https://togithub.com/AmeliasCode) in
[https://github.com/bazelbuild/rules_rust/pull/2683](https://togithub.com/bazelbuild/rules_rust/pull/2683)
- Release 0.46.0 by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_rust/pull/2686](https://togithub.com/bazelbuild/rules_rust/pull/2686)

##### New Contributors

- [@&#8203;mattem](https://togithub.com/mattem) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2660](https://togithub.com/bazelbuild/rules_rust/pull/2660)
- [@&#8203;EdSchouten](https://togithub.com/EdSchouten) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2671](https://togithub.com/bazelbuild/rules_rust/pull/2671)
- [@&#8203;mmorel-35](https://togithub.com/mmorel-35) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2678](https://togithub.com/bazelbuild/rules_rust/pull/2678)
- [@&#8203;ograff](https://togithub.com/ograff) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2674](https://togithub.com/bazelbuild/rules_rust/pull/2674)
- [@&#8203;Pagten](https://togithub.com/Pagten) made their first
contribution in
[https://github.com/bazelbuild/rules_rust/pull/2682](https://togithub.com/bazelbuild/rules_rust/pull/2682)

**Full Changelog**:
bazelbuild/rules_rust@0.45.1...0.46.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen_rust_project doesn't work with bzlmod

5 participants