Easy cleanup steps of #117#121
Merged
mfarrugi merged 4 commits intobazelbuild:masterfrom Aug 21, 2018
Merged
Conversation
acmcarther
approved these changes
Aug 20, 2018
Collaborator
acmcarther
left a comment
acmcarther
left a comment
There was a problem hiding this comment.
LGTM. I very slightly prefer "rust_bench" over "rust_benchmark" as "bench" is typically the jargon used, but I don't feel strongly about that at all. You probably chose "benchmark" for a particular reason.
| <li><a href="#rust_binary">rust_binary</a></li> | ||
| <li><a href="#rust_test">rust_test</a></li> | ||
| <li><a href="#rust_bench_test">rust_bench_test</a></li> | ||
| <li><a href="#rust_benchmark">rust_benchmark</a></li> |
Collaborator
There was a problem hiding this comment.
benchmark, not bench?
Not sure what the convention is.
Collaborator
Author
|
I thought benchmark better matched {binary, library, test}, as opposed to {bin, lib, test}. I don't care about the name.. but it's a breaking change so I am happy to wait a little bit for other comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also started on consolidating and simplifying rule impls, should have something for that later today.