Support compression_level when using xz#988
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Nov 26, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mathukumillia
force-pushed
the
add_xz_compression_level_support
branch
from
37c1f77 to
47b7230
Compare
Making buildifier happy to save a review loop.
aiuto
approved these changes
Nov 26, 2025
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Just trying to fix the buildifier warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
pkg_tarrule does not use thecompression_levelparameter whenxzcompression is selected. This patch fixes that. It also adds a test that verifies that using different compression levels results in different sizes.Fixes: #987
CHANGE_LOG