Implement pkg_install(symlink) also for pkg_zip#982
Merged
tonyaiuto merged 1 commit intobazelbuild:mainfrom Nov 13, 2025
Merged
Implement pkg_install(symlink) also for pkg_zip#982tonyaiuto merged 1 commit intobazelbuild:mainfrom
tonyaiuto merged 1 commit intobazelbuild:mainfrom
Conversation
cgrindel
reviewed
Oct 22, 2025
Collaborator
|
@adrianimboden It looks like there may be some linting issues. Can you investigate? |
adrianimboden
force-pushed
the
sync_20251022131430
branch
from
f96b3c3 to
93aceef
Compare
adrianimboden
force-pushed
the
sync_20251022131430
branch
from
93aceef to
0fa07e1
Compare
tonyaiuto
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I start to use hermetic python environment and saw #929.
It mostly works, but in my case I use pkg_zip instead of pkg_tar.
4eed546 implements
raw_symlink/ support forpkg_tar.This MR adds the same functionality for
pkg_zip.The exception when the feature is not implemented yet: