📦 Conditionally preserve file mtime when archiving through pkg_tar#974
Merged
aiuto merged 5 commits intobazelbuild:mainfrom Sep 11, 2025
Merged
📦 Conditionally preserve file mtime when archiving through pkg_tar#974aiuto merged 5 commits intobazelbuild:mainfrom
aiuto merged 5 commits intobazelbuild:mainfrom
Conversation
ronodnn
changed the title
cgrindel
approved these changes
Aug 16, 2025
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
Small formatting comment. Otherwise, LGTM.
added 2 commits
August 18, 2025 10:58
Contributor
Author
aiuto
approved these changes
Sep 11, 2025
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Sorry for the slow response. Good sailing weather last week.
aiuto
pushed a commit
to aiuto/rules_pkg
that referenced
this pull request
Sep 11, 2025
…azelbuild#974) * preserve file mtime through an option * add tests * delete debug comment * wrap long line * buildifier --------- Co-authored-by: rnascimento <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the new
preserve_mtimeflag is enabled, set mtime by extracting it from the file's mtime attribute. Thepreserve_mtimeflag is disabled by default.This is related to Issue bazelbuild/bazel#1299