Add pkg_rpm() "data" attribute to provide files for rpmbuild#964
Merged
tonyaiuto merged 1 commit intobazelbuild:mainfrom Jun 27, 2025
Merged
Add pkg_rpm() "data" attribute to provide files for rpmbuild#964tonyaiuto merged 1 commit intobazelbuild:mainfrom
tonyaiuto merged 1 commit intobazelbuild:mainfrom
Conversation
When building debuginfo packages, find-debuginfo is called by
rpmbuild. To include the relevant source files, they will need to be
accessible to find-debuginfo via rpmbuild.
There are a number of other pieces required for an end-to-end solution
with debuginfo, but they're outside the scope of rules_pkg, e.g.
- customized find-debuginfo that can run inside bazel
- special _find_debuginfo_opts used to locate source files
- figuring out which source files to pass to pkg_rpm() in the first
place.
The key, though, is that pkg_rpm() accepts extra data in the first
place.
Fixes: #965
tonyaiuto
approved these changes
Jun 27, 2025
Collaborator
tonyaiuto
left a comment
tonyaiuto
left a comment
There was a problem hiding this comment.
It would be great if you could do something with this in the rpmbuild example.
I see why this exists, but I have no clue about how and when you would need to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building debuginfo packages, find-debuginfo is called by rpmbuild. To include the relevant source files, they will need to be accessible to find-debuginfo via rpmbuild.
There are a number of other pieces required for an end-to-end solution with debuginfo, but they're outside the scope of rules_pkg, e.g.
The key, though, is that pkg_rpm() accepts extra data in the first place.
Fixes: #965