Skip to content

Remove incompatible_use_toolchain_transition again, now that it has been removed from bazel#963

Merged
tonyaiuto merged 1 commit intobazelbuild:mainfrom
mostynb:remove_incompatible_use_toolchain_transition_again
Jun 25, 2025
Merged

Remove incompatible_use_toolchain_transition again, now that it has been removed from bazel#963
tonyaiuto merged 1 commit intobazelbuild:mainfrom
mostynb:remove_incompatible_use_toolchain_transition_again

Conversation

@mostynb
Copy link
Copy Markdown
Contributor

@mostynb mostynb commented Jun 23, 2025

I think this might break compatibility with bazel 4.x, in order to fix compatibility with the tip of bazel's master branch.

Resolves #962
See also: #452, #454

cc @katre

…een removed from bazel

This breaks compatibility with bazel 4.x, in order to fix compatibility with
the tip of bazel's master branch.

Resolves bazelbuild#962
See also: bazelbuild#452, bazelbuild#454
Copy link
Copy Markdown
Collaborator

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I will not merge this yet so that @aiuto can review as well.

@tonyaiuto tonyaiuto merged commit 359ea46 into bazelbuild:main Jun 25, 2025
3 checks passed
@mostynb mostynb deleted the remove_incompatible_use_toolchain_transition_again branch June 25, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incompatible_use_toolchain_transition has been removed from the tip of bazel's master branch, rules_pkg fails to build.

3 participants