rpm: fix sub-RPM post_scriptlet and add %postun support#934
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Feb 21, 2025
Merged
rpm: fix sub-RPM post_scriptlet and add %postun support#934aiuto merged 1 commit intobazelbuild:mainfrom
aiuto merged 1 commit intobazelbuild:mainfrom
Conversation
The existing implementation of `%post` neglected to actually include
the contents of the `%post` scriptlet and simply added a `%post`
section to the spec file without the body, e.g.
%post sub
%files sub
...
With this change, I've also added support for `%postun` and included
the scriptlet support in the `test_golden_sub_rpm_contents` test case.
Collaborator
|
@aiuto It appears the CI failures are unrelated to the PR. How do you usually handle this? |
aiuto
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation of
%postneglected to actually include the contents of the%postscriptlet and simply added a%postsection to the spec file without the body, e.g.With this change, I've also added support for
%postunand included the scriptlet support in thetest_golden_sub_rpm_contentstest case.