rpm: Consume group info for sub RPMs#931
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Feb 5, 2025
Merged
Conversation
In the original subrpm implementation this field appears to have been overlooked. This change just injects the correct specfile lines based on the existing group info from the provider.
cgrindel
approved these changes
Jan 30, 2025
Collaborator
|
This looks good to me. I won't merge it quite yet. I want to be sure that @aiuto has a chance to review if he would like to do so. |
Contributor
Author
|
@aiuto any feedback on this? |
aiuto
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original subrpm implementation this field appears to have been overlooked. This change just injects the correct specfile lines based on the existing group info from the provider.