Allow some common rule args in verify_archive_test#917
Merged
aiuto merged 7 commits intobazelbuild:mainfrom Jan 15, 2025
Merged
Allow some common rule args in verify_archive_test#917aiuto merged 7 commits intobazelbuild:mainfrom
aiuto merged 7 commits intobazelbuild:mainfrom
Conversation
Contributor
Author
|
I'll keep it as a draft until CI passes :) |
Contributor
passed |
Contributor
Author
|
I'm making it a draft for a moment - the |
aiuto
reviewed
Jan 14, 2025
aiuto
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #916
This is my proposal for allowing common test arguments for
verify_archive_test.