Skip to content

Allow some common rule args in verify_archive_test#917

Merged
aiuto merged 7 commits intobazelbuild:mainfrom
krakeusz:feat/verify_archive_test_kwargs
Jan 15, 2025
Merged

Allow some common rule args in verify_archive_test#917
aiuto merged 7 commits intobazelbuild:mainfrom
krakeusz:feat/verify_archive_test_kwargs

Conversation

@krakeusz
Copy link
Copy Markdown
Contributor

Closes #916

This is my proposal for allowing common test arguments for verify_archive_test.

@krakeusz
Copy link
Copy Markdown
Contributor Author

I'll keep it as a draft until CI passes :)

@hofbi
Copy link
Copy Markdown
Contributor

hofbi commented Jan 13, 2025

I'll keep it as a draft until CI passes :)

passed

@krakeusz krakeusz marked this pull request as ready for review January 13, 2025 17:55
@krakeusz
Copy link
Copy Markdown
Contributor Author

I'm making it a draft for a moment - the kwargs need to be forwarded to _gen_verify_archive_test_main as well. I'll add a test as well.

@krakeusz krakeusz marked this pull request as draft January 14, 2025 12:43
@krakeusz krakeusz changed the title Forward kwargs from verify_archive_test to py_test Allow some common rule args in verify_archive_test Jan 14, 2025
@krakeusz krakeusz marked this pull request as ready for review January 14, 2025 14:26
@aiuto aiuto merged commit 12fed4b into bazelbuild:main Jan 15, 2025
@krakeusz krakeusz deleted the feat/verify_archive_test_kwargs branch January 15, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify_archive_test doesn't allow common test attrs

3 participants