Closed
Conversation
Contributor
Author
|
This is a follow-up to #909 |
Collaborator
|
I just sent #915 to fix the test and only that. You have a bunch of other changes here that seem much larger. Did you need to make those for your environment? |
Contributor
Author
These changes were not required. It was just a formatter that ran on saving the file in my IDE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix one unit test after #910 was merged. I assume that PR must have been merged with red CI.
With this PR, all should be good now. Some of the changes are just my Buildifier kicking in.