install: Add --wipe_destdir option#894
Merged
aiuto merged 3 commits intobazelbuild:mainfrom Sep 28, 2024
Merged
Conversation
Cleans up a lot of code!
If specified, wipe destination directory before installing. Fixes bazelbuild#893.
aiuto
approved these changes
Sep 25, 2024
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Your call on the doc wording.
Clarify that this will delete the whole directory.
Contributor
Author
|
The test error seemed unrelated to my patch. How do I re-run the test? |
Collaborator
They are unrelated errors. Something change in Bazel at head that is breaking a few of these. It's not that Bazel is really broken either, it's that we have tests for compatibility against WORKSPACE too, and Bazel is rapidly deprecating support for that. I will force merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If specified, wipe destination directory before installing.
Fixes #893.