Exclude release from filename when using release_file#863
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Apr 29, 2024
Merged
Exclude release from filename when using release_file#863aiuto merged 2 commits intobazelbuild:mainfrom
aiuto merged 2 commits intobazelbuild:mainfrom
Conversation
When we're using `release_file` in lieu of `release` we're just pointing rpmbuild at the file containing the `Release` string and we don't have it available to inject into the filename resulting in a strange looking filename of the form `Foo-version-.arch.rpm`. This change extracts the RPM name generation to a single helper, `_make_rpm_filename` and tweaks it s.t. if we're missing the value for `release` we'll just exclude it from the filename format instead.
The test had was using the odd RPM name structure and this change tweaks it so that the test passes.
aiuto
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we're using
release_filein lieu ofreleasewe're just pointing rpmbuild at the file containing theReleasestring and we don't have it available to inject into the filename resulting in a strange looking filename of the formFoo-version-.arch.rpm.This change extracts the RPM name generation to a single helper,
_make_rpm_filenameand tweaks it s.t. if we're missing the value forreleasewe'll just exclude it from the filename format instead.