Merged
Conversation
alexeagle
reviewed
Oct 29, 2023
Contributor
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
You could rebase after the runfiles change landed to make the delta smaller?
Wyverald
reviewed
Oct 30, 2023
Wyverald
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work.
I don't like the bzlmod setup for the rpm toolchains, in that you must use the string "rules_pkg_rpmbuild".
That name is not great, and it should really be opaque, because no one cares what it is.
But, this is good enough for now, so at least we have a test run working.