Skip to content

Add changelog attribute to pkg_deb#725

Merged
aiuto merged 1 commit intobazelbuild:mainfrom
k0walik:add-changelog-to-pkg-deb
Aug 14, 2023
Merged

Add changelog attribute to pkg_deb#725
aiuto merged 1 commit intobazelbuild:mainfrom
k0walik:add-changelog-to-pkg-deb

Conversation

@k0walik
Copy link
Copy Markdown
Contributor

@k0walik k0walik commented Aug 11, 2023

Allow passing changelog file to pkg_deb rule.
This addresses #696 issue.

  Allow passing changelog file to pkg_deb rule
@k0walik
Copy link
Copy Markdown
Contributor Author

k0walik commented Aug 11, 2023

The open question is if we want to propagate content of the changelog file to generated .changes file (see make_deb.py). According to Debian documentation the Changes field is usually extracted from the changelog file. Thoughts?

@aiuto
Copy link
Copy Markdown
Collaborator

aiuto commented Aug 14, 2023

It should not automatically propagate to the .changes file. That choice should be up to each target. Personally, I would never put the raw changelog into a binary distribution anyway.

@aiuto aiuto merged commit d897540 into bazelbuild:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants