Add verify_archive rule to do e2e tests on built archives.#669
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Feb 15, 2023
Merged
Add verify_archive rule to do e2e tests on built archives.#669aiuto merged 1 commit intobazelbuild:mainfrom
aiuto merged 1 commit intobazelbuild:mainfrom
Conversation
We could do more, but this should be good enough to start. Fixes bazelbuild#644
sdtwigg
approved these changes
Feb 15, 2023
sdtwigg
left a comment
sdtwigg
left a comment
There was a problem hiding this comment.
docstrings look fine and sufficiently self-explanatory
Collaborator
Author
|
Thanks. |
Collaborator
Author
|
Actually, I need an approve review. |
Collaborator
Author
|
Oh.. weird, why didn't the approve from you work? I'll go hunt. Stay tuned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could do more, but this should be good enough to start.
Let's review this as is for the match, and then I will add zip support in a followup.
Fixes #644