Apply package_dir to pkg_mklink in pkg_tar#637
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Nov 23, 2022
Merged
Conversation
- Fix brokenness in pkg_tar - Add tests (it was working) to pkg_zip Fixes bazelbuild#610
nacl
approved these changes
Nov 23, 2022
Collaborator
nacl
left a comment
nacl
left a comment
There was a problem hiding this comment.
LGTM, but I wonder how well this scales. It probably works well enough in 99% of the use cases in any cases; see the comment below.
Also, on submit, please call out pkg_tar in the commit summary (first line).
aiuto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #610