Revert "Remove uses of incompatible_use_toolchain_transition now th…#454
Merged
nacl merged 1 commit intobazelbuild:mainfrom Nov 5, 2021
katre:restore-toolchain-transition
Merged
Revert "Remove uses of incompatible_use_toolchain_transition now th…#454nacl merged 1 commit intobazelbuild:mainfrom katre:restore-toolchain-transition
incompatible_use_toolchain_transition now th…#454nacl merged 1 commit intobazelbuild:mainfrom
katre:restore-toolchain-transition
Conversation
Collaborator
|
Does the option actually help with 4.x? I am using |
Contributor
Author
|
4.x will still work without this, but the tools may end up in the wrong configuration (especially with cross-compilation or remote executors). |
mostynb
added a commit
to mostynb/rules_pkg
that referenced
this pull request
Jun 23, 2025
…een removed from bazel This breaks compatibility with bazel 4.x, in order to fix compatibility with the tip of bazel's master branch. Resolves bazelbuild#962 See also: bazelbuild#452, bazelbuild#454
tonyaiuto
added a commit
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…at it is enabled by (#452)"
This is still needed for bazel 4.x compatibility, and it a no-op in
Bazel 5.x, so it should be kept.
The API will be removed in Bazel 6.0.
Part of bazelbuild/bazel#14127.
This reverts commit e203d5b.