Skip to content

Remove uses of incompatible_use_toolchain_transition now that it is…#452

Merged
aiuto merged 1 commit intobazelbuild:mainfrom
katre:remove-toolchain-transition
Oct 27, 2021
Merged

Remove uses of incompatible_use_toolchain_transition now that it is…#452
aiuto merged 1 commit intobazelbuild:mainfrom
katre:remove-toolchain-transition

Conversation

@katre
Copy link
Copy Markdown
Contributor

@katre katre commented Oct 27, 2021

… enabled by

default in Bazel 5.0.

This is a step towards removing it entirely.

Part of bazelbuild/bazel#14127.

… enabled by

default in Bazel 5.0.

This is a step towards removing it entirely.

Part of bazelbuild/bazel#14127.
@katre katre requested review from aiuto and nacl as code owners October 27, 2021 19:48
@aiuto aiuto merged commit e203d5b into bazelbuild:main Oct 27, 2021
@nacl
Copy link
Copy Markdown
Collaborator

nacl commented Oct 28, 2021

Correct me if I'm wrong, but could this cause issues with the 4.x series, where the setting is False by default?

@katre katre deleted the remove-toolchain-transition branch October 28, 2021 16:08
@katre
Copy link
Copy Markdown
Contributor Author

katre commented Oct 28, 2021

@nacl: you are correct, I'm sending a PR shortly to restore it.

nacl pushed a commit that referenced this pull request Nov 5, 2021
…at it is enabled by (#452)" (#454)

This is still needed for bazel 4.x compatibility, and it a no-op in
Bazel 5.x, so it should be kept.

The API will be removed in Bazel 6.0.

This reverts commit e203d5b.
mostynb added a commit to mostynb/rules_pkg that referenced this pull request Jun 23, 2025
…een removed from bazel

This breaks compatibility with bazel 4.x, in order to fix compatibility with
the tip of bazel's master branch.

Resolves bazelbuild#962
See also: bazelbuild#452, bazelbuild#454
tonyaiuto added a commit that referenced this pull request Jun 25, 2025
…een removed from bazel (#963)

I think this might break compatibility with bazel 4.x, in order to fix
compatibility with the tip of bazel's master branch.

Resolves #962
See also: #452, #454

cc @katre
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants