Consolidate make_rpm.bzl and experimental/make_rpm.bzl#179
Merged
aiuto merged 6 commits intobazelbuild:masterfrom Aug 4, 2020
Merged
Consolidate make_rpm.bzl and experimental/make_rpm.bzl#179aiuto merged 6 commits intobazelbuild:masterfrom
aiuto merged 6 commits intobazelbuild:masterfrom
Conversation
This change consolidates all of new features/fixes from pkg/experimental/make_rpm.bzl into pkg/make_rpm.bzl. Code used specifically by experimental/rpm.bzl is marked as such, and is grouped as to be generally obvious. Features now supported by non-experimental `pkg_rpm`: - Support for older versions of `rpm(8)` (creation of `RPMS` output directory) Features supported by non-experimental `pkg_rpm` not supported by experimental `pkg_rpm`: - Support for `SOURCE_DATE_EPOCH` Fixes bazelbuild#173
aiuto
reviewed
May 19, 2020
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Only some nits about indents and comments.
aiuto
requested changes
Jun 10, 2020
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
I think the hard part of this CL is not the logic, but the fact that the why of how each file is treated might be underdocumented. Since this is not code that we touch frequently, we need to relearn the interaction of the rule, make_rpm and rpmbuild anew each time.
Perhaps it is time to document that. If not in this PR, but shortly after.
This was referenced Aug 3, 2020
- Discontinuing use of `str.format` in `CallRpmBuild()` - Move RPM spec fields away from the `RpmBuilder` constructor and into `SetupWorkdir()`. Initialize values set up in `RpmBuilder` to `None` in the constructor. - Additional comments in `SetupWorkdir()` to clarify the purpose of the various actions taken there.
aiuto
approved these changes
Aug 4, 2020
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
We should burn make_rpm down and start fresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consolidates all of new features/fixes from
pkg/experimental/make_rpm.bzl into pkg/make_rpm.bzl.
Code used specifically by experimental/rpm.bzl is marked as such, and is grouped
as to be generally obvious.
Features now supported by non-experimental
pkg_rpm:rpm(8)(creation ofRPMSoutput directory)Features supported by non-experimental
pkg_rpmnot supported by experimentalpkg_rpm:SOURCE_DATE_EPOCHFixes #173.