Mass pkgfilegroup -> pkg_filegroup rename#156
Merged
aiuto merged 1 commit intobazelbuild:masterfrom Apr 16, 2020
Merged
Conversation
This change renames all instances of `pkgfilegroup` to `pkg_filegroup`, and renames `experimental/genpkg.bzl` to `experimental/pkg_filegroup.bzl`. Names of tests and documentation have been updated accordingly. The change was mostly made mechanically using `sed(1)`, with minor cleanup afterward. This change makes the names within the experimental/ directory consistent, and was requested in the review of bazelbuild#129.
aiuto
approved these changes
Apr 16, 2020
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Sweet. I love changes that I can review in 20 seconds or less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames all instances of
pkgfilegrouptopkg_filegroup, andrenames
experimental/genpkg.bzltoexperimental/pkg_filegroup.bzl.Names of tests and documentation have been updated accordingly. The change was
mostly made mechanically using
sed(1), with minor cleanup afterward.This change makes the names within the experimental/ directory consistent, and was
requested in the review of #129.