-
Notifications
You must be signed in to change notification settings - Fork 217
remap_paths from pkg_tar should apply to runfiles #790
Copy link
Copy link
Closed
Labels
P3An issue that we are not working on but will review quarterlyAn issue that we are not working on but will review quarterly
Description
The new implementation of include_runfiles for pkg_tar performs path remapping only on the binaries, and then roots the runfiles in <remapped_binary_path>.runfiles. The runfiles themselves are not remapped, so placing them in a different location is not possible.
My use case for this is placing C++ .so dependencies in a different path (/lib) This would be easy to achieve if remapping applied to runfiles.
My proposed change would be applying remapping to individual runfiles, instead of to the root folder only. I have it working in main...dieortin:rules_pkg:tar-runfile-mapping and would be happy to work on a PR if you think this makes sense.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3An issue that we are not working on but will review quarterlyAn issue that we are not working on but will review quarterly