Add support for --incompatible_compact_repo_mapping_manifest#301
Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Closed
Add support for --incompatible_compact_repo_mapping_manifest#301fmeum wants to merge 2 commits intobazelbuild:masterfrom
--incompatible_compact_repo_mapping_manifest#301fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
5 tasks
Contributor
Author
|
@meteorcloudy Could you review this? CI failures are unrelated. |
Member
meteorcloudy
approved these changes
Jun 11, 2025
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Thanks! Should we explicitly point out that the new runfiles library is also compatible with the old format?
fmeum
force-pushed
the
compact-repo-mapping
branch
from
394665e to
678ea6d
Compare
Contributor
Author
I will point this out on the migration issue instead, I think: the old format is indistinguishable from a subset of the new format, so this is not really a property of the concrete implementation. |
Member
|
Ah, I saw the internal CL |
fmeum
added a commit
to fmeum/rules_java
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new
_repo_mappingformat introduced in bazelbuild/bazel#26262 to the runfiles library.