Skip to content

Add JDK 21 toolchain for linux_riscv64#258

Closed
JackWolfard wants to merge 1 commit intobazelbuild:masterfrom
JackWolfard:jdk21-riscv64
Closed

Add JDK 21 toolchain for linux_riscv64#258
JackWolfard wants to merge 1 commit intobazelbuild:masterfrom
JackWolfard:jdk21-riscv64

Conversation

@JackWolfard
Copy link
Contributor

A Googler will need to help add the mirror for Adoptium Temurin's 21.0.4+7 JDK release for linux_riscv64

@JackWolfard JackWolfard requested review from a team and comius as code owners January 6, 2025 23:59
@JackWolfard
Copy link
Contributor Author

I have confirmed bazel build //distro/... works locally as well as bazel test //java/test/..., but I was unable to get bazel test //test/... to work due to stardoc+/stardoc/proto/BUILD: no such target '@@stardoc+//stardoc/proto:stardoc_output_java_proto': target 'stardoc_output_java_proto' not declared in package 'stardoc/proto'

@JackWolfard
Copy link
Contributor Author

The CI failure is due to the missing mirror which I cannot add. If I was to remove this mirror url, then another test would fail due to Adoptium JDK sources being expected to have both a GitHub and a mirror url.

Missing mirror URLs:
  https://mirror.bazel.build/github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.4+7/OpenJDK21U-jdk_riscv64_linux_hotspot_21.0.4_7.tar.gz

@fmeum
Copy link
Contributor

fmeum commented Jan 7, 2025

@JackWolfard
Copy link
Contributor Author

@JackWolfard
Copy link
Contributor Author

With the mirror url now available, I have confirmed the failing test //test:check_remote_jdk_configs_test passes locally using Bazel 8.0.0. I am unable to retrigger the failing job in Buildkite, so a maintainer will need to help rerun CI again.

$ bazel test //test:check_remote_jdk_configs_test
INFO: Analyzed target //test:check_remote_jdk_configs_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
Target //test:check_remote_jdk_configs_test up-to-date:
  bazel-bin/test/check_remote_jdk_configs_test
INFO: Elapsed time: 160.602s, Critical Path: 160.48s
INFO: 2 processes: 1 action cache hit, 2 linux-sandbox.
INFO: Build completed successfully, 2 total actions
//test:check_remote_jdk_configs_test                                     PASSED in 160.4s

Executed 1 out of 1 test: 1 test passes.

@copybara-service copybara-service bot closed this in 43ca043 Jan 9, 2025
kxxt pushed a commit to kxxt/rules_java that referenced this pull request Mar 25, 2025
Copybara Import from bazelbuild#258

BEGIN_PUBLIC
Add JDK 21 toolchain for `linux_riscv64` (bazelbuild#258)

A Googler will need to help add the mirror for Adoptium Temurin's 21.0.4+7 JDK release for `linux_riscv64`
* https://bazel.googlesource.com/continuous-integration/+/refs/heads/master/docs/mirror.md

Closes bazelbuild#258
END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=bazelbuild#258 from JackWolfard:jdk21-riscv64 4df051d
PiperOrigin-RevId: 713668463
Change-Id: I2b7f15bcef430654077df27475dedd4453a1d9ce
hvadehra pushed a commit that referenced this pull request Mar 25, 2025
This is a cherry-pick of #258 into 7.x.

A new release would be appreciated as building bazel 7.x on riscv64
would require this.

---------

Co-authored-by: Jack Wolfard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants