Fix import (fixes --noexperimental_python_import_all_repositories)#2171
Merged
uhthomas merged 2 commits intobazelbuild:masterfrom Jan 14, 2023
Merged
Fix import (fixes --noexperimental_python_import_all_repositories)#2171uhthomas merged 2 commits intobazelbuild:masterfrom
uhthomas merged 2 commits intobazelbuild:masterfrom
Conversation
AugustKarlstedt
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
AugustKarlstedt
changed the title
Contributor
Author
|
also fixes CI... can split into separate PR |
Collaborator
|
I think CI is fixed now. If you want to update this PR with just your changes I'm happy to approve it. |
AugustKarlstedt
force-pushed
the
patch-1
branch
from
9efa85d to
b4209b9
Compare
Update presubmit.yml Update BUILD Update BUILD revert some stuff from bazelbuild#2098 goldens n Revert "n" This reverts commit 8c094e7. Revert "goldens" This reverts commit ce1ff41. Revert "revert some stuff from bazelbuild#2098" This reverts commit afb5787. Revert "Update presubmit.yml" This reverts commit bf40dad.
AugustKarlstedt
force-pushed
the
patch-1
branch
from
b4209b9 to
9e4321b
Compare
uhthomas
approved these changes
Jan 14, 2023
Collaborator
|
Thank you! :) |
dieend
pushed a commit
to brexhq/rules_docker
that referenced
this pull request
Dec 13, 2024
Update presubmit.yml Update BUILD Update BUILD revert some stuff from bazelbuild#2098 goldens n Revert "n" This reverts commit 8c094e7. Revert "goldens" This reverts commit ce1ff41. Revert "revert some stuff from bazelbuild#2098" This reverts commit afb5787. Revert "Update presubmit.yml" This reverts commit bf40dad.
dieend
pushed a commit
to brexhq/rules_docker
that referenced
this pull request
Jan 24, 2025
Update presubmit.yml Update BUILD Update BUILD revert some stuff from bazelbuild#2098 goldens n Revert "n" This reverts commit 8c094e7. Revert "goldens" This reverts commit ce1ff41. Revert "revert some stuff from bazelbuild#2098" This reverts commit afb5787. Revert "Update presubmit.yml" This reverts commit bf40dad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current import implicitly relies on the behavior where every immediate sub-directory under the runfiles root is added to
PYTHONPATHIssue Number: N/A
What is the new behavior?
Removes this assumption, which fixes an incompatibility with
--noexperimental_python_import_all_repositoriesDoes this PR introduce a breaking change?
Other information
see bazel-contrib/rules_python#792